Commit ccc40d42 authored by Aashish Sharma's avatar Aashish Sharma Committed by Rob Clark
Browse files

drm/msm: Remove redundant check for 'submit' 



Rectify the below smatch warning:
drivers/gpu/drm/msm/msm_gem_submit.c:963 msm_ioctl_gem_submit() warn:
variable dereferenced before check 'submit'

'submit' is normally error pointer or valid, so remove its NULL
initializer as it's confusing and also remove a redundant check for it's
value.

Signed-off-by: default avatarAashish Sharma <shraash@google.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/506653/
Link: https://lore.kernel.org/r/20221011075519.3111928-1-shraash@google.com


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent ec4fbd79

drivers/gpu/drm/msm/msm_gem_submit.c

+2 −3
Original line number Diff line number Diff line
@@ -706,7 +706,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, 
	struct msm_drm_private *priv = dev->dev_private;

	struct drm_msm_gem_submit *args = data;

	struct msm_file_private *ctx = file->driver_priv;

	struct msm_gem_submit *submit = NULL;

	struct msm_gem_submit *submit;

	struct msm_gpu *gpu = priv->gpu;

	struct msm_gpu_submitqueue *queue;

	struct msm_ringbuffer *ring;
@@ -946,7 +946,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, 
		put_unused_fd(out_fence_fd);

	mutex_unlock(&queue->lock);

out_post_unlock:

	if (submit)

	msm_gem_submit_put(submit);

	if (!IS_ERR_OR_NULL(post_deps)) {

		for (i = 0; i < args->nr_out_syncobjs; ++i) {