Commit cca21000 authored by Souptick Joarder's avatar Souptick Joarder Committed by Bjorn Andersson
Browse files

remoteproc/mediatek: Fix kernel test robot warning 



Kernel test robot throws below warning ->

>> drivers/remoteproc/mtk_scp.c:755:37: warning: unused variable
>> 'mt8183_of_data' [-Wunused-const-variable]
   static const struct mtk_scp_of_data mt8183_of_data = {
                                       ^
>> drivers/remoteproc/mtk_scp.c:765:37: warning: unused variable
>> 'mt8192_of_data' [-Wunused-const-variable]
   static const struct mtk_scp_of_data mt8192_of_data = {
                                       ^
As suggested by Bjorn, there's no harm in just dropping the
of_match_ptr() wrapping of mtk_scp_of_match in the definition of
mtk_scp_driver and we avoid this whole problem.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Suggested-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarSouptick Joarder <jrdr.linux@gmail.com>
Link: https://lore.kernel.org/r/1606513855-21130-1-git-send-email-jrdr.linux@gmail.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 6dfdf6e4

drivers/remoteproc/mtk_scp.c

+1 −3
Original line number Diff line number Diff line
@@ -772,21 +772,19 @@ static const struct mtk_scp_of_data mt8192_of_data = { 
	.host_to_scp_int_bit = MT8192_HOST_IPC_INT_BIT,

};



#if defined(CONFIG_OF)

static const struct of_device_id mtk_scp_of_match[] = {

	{ .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },

	{ .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },

	{},

};

MODULE_DEVICE_TABLE(of, mtk_scp_of_match);

#endif



static struct platform_driver mtk_scp_driver = {

	.probe = scp_probe,

	.remove = scp_remove,

	.driver = {

		.name = "mtk-scp",

		.of_match_table = of_match_ptr(mtk_scp_of_match),

		.of_match_table = mtk_scp_of_match,

	},

};