Commit cc94d47c authored by Ricardo Koller's avatar Ricardo Koller Committed by Marc Zyngier
Browse files

kvm: selftests: aarch64: fix assert in gicv3_access_reg 



The val argument in gicv3_access_reg can have any value when used for a
read, not necessarily 0.  Fix the assert by checking val only for
writes.

Signed-off-by: default avatarRicardo Koller <ricarkol@google.com>
Reported-by: default avatarReiji Watanabe <reijiw@google.com>
Cc: Andrew Jones <drjones@redhat.com>
Reviewed-by: default avatarAndrew Jones <drjones@redhat.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220127030858.3269036-2-ricarkol@google.com
parent dfd42fac

tools/testing/selftests/kvm/lib/aarch64/gic_v3.c

+1 −1
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ static void gicv3_access_reg(uint32_t intid, uint64_t offset, 
	uint32_t cpu_or_dist;



	GUEST_ASSERT(bits_per_field <= reg_bits);

	GUEST_ASSERT(*val < (1U << bits_per_field));

	GUEST_ASSERT(!write || *val < (1U << bits_per_field));

	/* Some registers like IROUTER are 64 bit long. Those are currently not

	 * supported by readl nor writel, so just asserting here until then.

	 */