Commit cc4598cf authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller
Browse files

net/fsl: xgmac_mdio: fix return value check in xgmac_mdio_probe() 



In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 1d14eb15 ("net/fsl: xgmac_mdio: Use managed device resources")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarTobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47ed9442

drivers/net/ethernet/freescale/xgmac_mdio.c

+2 −2
Original line number Diff line number Diff line
@@ -335,8 +335,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev) 
	priv = bus->priv;

	priv->mdio_base = devm_ioremap(&pdev->dev, res->start,

				       resource_size(res));

	if (IS_ERR(priv->mdio_base))

		return PTR_ERR(priv->mdio_base);

	if (!priv->mdio_base)

		return -ENOMEM;



	/* For both ACPI and DT cases, endianness of MDIO controller

	 * needs to be specified using "little-endian" property.