Commit cc398a34 authored by Martin Habets's avatar Martin Habets Committed by Jakub Kicinski
Browse files

sfc/siena: Remove duplicate check on segments 



Siena only supports software TSO. This means more code can be deleted,
as pointed out by the Smatch static checker warning:
	drivers/net/ethernet/sfc/siena/tx.c:184 __efx_siena_enqueue_skb()
	warn: duplicate check 'segments' (previous on line 158)

Fixes: 956f2d86 ("sfc/siena: Remove build references to missing functionality")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/kernel-janitors/YoH5tJMnwuGTrn1Z@kili/


Signed-off-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Link: https://lore.kernel.org/r/165294463549.23865.4557617334650441347.stgit@palantir17.mph.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dc776924

drivers/net/ethernet/sfc/siena/tx.c

+1 −8
Original line number Diff line number Diff line
@@ -181,14 +181,7 @@ netdev_tx_t __efx_siena_enqueue_skb(struct efx_tx_queue *tx_queue, 
	if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more))

		efx_tx_send_pending(tx_queue->channel);



	if (segments) {

		tx_queue->tso_bursts++;

		tx_queue->tso_packets += segments;

		tx_queue->tx_packets  += segments;

	} else {

	tx_queue->tx_packets++;

	}



	return NETDEV_TX_OK;