Commit cc317ea3 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by David S. Miller
Browse files

bonding: remove redundant NULL check in debugfs function 



Because debugfs_create_dir returns ERR_PTR, so bonding_debug_root will
never be NULL. Remove redundant NULL check for bonding_debug_root in
debugfs function. The later debugfs_create_dir/debugfs_remove_recursive
/debugfs_remove_recursive functions will check the dentry with IS_ERR().

Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57647e6f

drivers/net/bonding/bond_debugfs.c

+0 −9
Original line number Diff line number Diff line
@@ -49,9 +49,6 @@ DEFINE_SHOW_ATTRIBUTE(bond_debug_rlb_hash); 


void bond_debug_register(struct bonding *bond)

{

	if (!bonding_debug_root)

		return;



	bond->debug_dir =

		debugfs_create_dir(bond->dev->name, bonding_debug_root);
@@ -61,9 +58,6 @@ void bond_debug_register(struct bonding *bond) 


void bond_debug_unregister(struct bonding *bond)

{

	if (!bonding_debug_root)

		return;



	debugfs_remove_recursive(bond->debug_dir);

}
@@ -71,9 +65,6 @@ void bond_debug_reregister(struct bonding *bond) 
{

	struct dentry *d;



	if (!bonding_debug_root)

		return;



	d = debugfs_rename(bonding_debug_root, bond->debug_dir,

			   bonding_debug_root, bond->dev->name);

	if (!IS_ERR(d)) {