Commit cc03facb authored by Ye Guojin's avatar Ye Guojin Committed by Martin K. Petersen
Browse files

scsi: ufs: ufs-mediatek: Add put_device() after of_find_device_by_node() 

This was found by coccicheck:

./drivers/scsi/ufs/ufs-mediatek.c, 211, 1-7, ERROR missing put_device;
call of_find_device_by_node on line 1185, but without a corresponding
object release within this function.

Link: https://lore.kernel.org/r/20211110105133.150171-1-ye.guojin@zte.com.cn


Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Reviewed-by: default avatarPeter Wang <peter.wang@mediatek.com>
Signed-off-by: default avatarYe Guojin <ye.guojin@zte.com.cn>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 36e07d7e

drivers/scsi/ufs/ufs-mediatek.c

+1 −0
Original line number Diff line number Diff line
@@ -1189,6 +1189,7 @@ static int ufs_mtk_probe(struct platform_device *pdev) 
	}

	link = device_link_add(dev, &reset_pdev->dev,

		DL_FLAG_AUTOPROBE_CONSUMER);

	put_device(&reset_pdev->dev);

	if (!link) {

		dev_notice(dev, "add reset device_link fail\n");

		goto skip_reset;