Commit cbf11071 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: convert some sysctls into module parameters 



Parameters like the minimum reserved port, and the number of slot entries
should really be module parameters rather than sysctls.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 80e52ace

Documentation/kernel-parameters.txt

+21 −0
Original line number Diff line number Diff line
@@ -2391,6 +2391,18 @@ and is between 256 and 4096 characters. It is defined in the file 
	stifb=		[HW]

			Format: bpp:<bpp1>[:<bpp2>[:<bpp3>...]]



	sunrpc.min_resvport=

	sunrpc.max_resvport=

			[NFS,SUNRPC]

			SunRPC servers often require that client requests

			originate from a privileged port (i.e. a port in the

			range 0 < portnr < 1024).

			An administrator who wishes to reserve some of these

			ports for other uses may adjust the range that the

			kernel's sunrpc client considers to be privileged

			using these two parameters to set the minimum and

			maximum port values.



	sunrpc.pool_mode=

			[NFS]

			Control how the NFS server code allocates CPUs to
@@ -2407,6 +2419,15 @@ and is between 256 and 4096 characters. It is defined in the file 
			pernode	    one pool for each NUMA node (equivalent

				    to global on non-NUMA machines)



	sunrpc.tcp_slot_table_entries=

	sunrpc.udp_slot_table_entries=

			[NFS,SUNRPC]

			Sets the upper limit on the number of simultaneous

			RPC calls that can be sent from the client to a

			server. Increasing these values may allow you to

			improve throughput, but will also increase the

			amount of memory reserved for use by the client.



	swiotlb=	[IA-64] Number of I/O TLB slabs



	switches=	[HW,M68k]

net/sunrpc/xprtsock.c

+52 −0
Original line number Diff line number Diff line
@@ -2412,3 +2412,55 @@ void cleanup_socket_xprt(void) 
	xprt_unregister_transport(&xs_udp_transport);

	xprt_unregister_transport(&xs_tcp_transport);

}



static int param_set_uint_minmax(const char *val, struct kernel_param *kp,

		unsigned int min, unsigned int max)

{

	unsigned long num;

	int ret;



	if (!val)

		return -EINVAL;

	ret = strict_strtoul(val, 0, &num);

	if (ret == -EINVAL || num < min || num > max)

		return -EINVAL;

	*((unsigned int *)kp->arg) = num;

	return 0;

}



static int param_set_portnr(const char *val, struct kernel_param *kp)

{

	return param_set_uint_minmax(val, kp,

			RPC_MIN_RESVPORT,

			RPC_MAX_RESVPORT);

}



static int param_get_portnr(char *buffer, struct kernel_param *kp)

{

	return param_get_uint(buffer, kp);

}

#define param_check_portnr(name, p) \

	__param_check(name, p, unsigned int);



module_param_named(min_resvport, xprt_min_resvport, portnr, 0644);

module_param_named(max_resvport, xprt_max_resvport, portnr, 0644);



static int param_set_slot_table_size(const char *val, struct kernel_param *kp)

{

	return param_set_uint_minmax(val, kp,

			RPC_MIN_SLOT_TABLE,

			RPC_MAX_SLOT_TABLE);

}



static int param_get_slot_table_size(char *buffer, struct kernel_param *kp)

{

	return param_get_uint(buffer, kp);

}

#define param_check_slot_table_size(name, p) \

	__param_check(name, p, unsigned int);



module_param_named(tcp_slot_table_entries, xprt_tcp_slot_table_entries,

		   slot_table_size, 0644);

module_param_named(udp_slot_table_entries, xprt_udp_slot_table_entries,

		   slot_table_size, 0644);