Commit cbedb42a authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Daniel Borkmann
Browse files

bpf: Avoid incorrect -EFAULT error in BPF_LOG_KERNEL mode 



If verifier log is in BPF_LOG_KERNEL mode, no log->ubuf is expected and
it stays NULL throughout entire verification process. Don't erroneously
return -EFAULT in such case.

Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarLorenz Bauer <lmb@isovalent.com>
Link: https://lore.kernel.org/bpf/20230406234205.323208-10-andrii@kernel.org
parent 971fb505

kernel/bpf/verifier.c

+1 −1
Original line number Diff line number Diff line
@@ -18863,7 +18863,7 @@ int bpf_check(struct bpf_prog **prog, union bpf_attr *attr, bpfptr_t uattr) 
	bpf_vlog_finalize(log);

	if (log->level && bpf_vlog_truncated(log))

		ret = -ENOSPC;

	if (log->level && !log->ubuf) {

	if (log->level && log->level != BPF_LOG_KERNEL && !log->ubuf) {

		ret = -EFAULT;

		goto err_release_maps;

	}