Commit cbea2170 authored by Namhyung Kim's avatar Namhyung Kim Committed by NeilBrown
Browse files

md/raid10: move rdev->corrected_errors counting 



Read errors are considered to corrected if write-back and re-read
cycle is finished without further problems. Thus moving the rdev->
corrected_errors counting after the re-reading looks more reasonable
IMHO.

Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent ddd5115f

drivers/md/raid10.c

+1 −1
Original line number Diff line number Diff line
@@ -1533,7 +1533,6 @@ static void fix_read_error(conf_t *conf, mddev_t *mddev, r10bio_t *r10_bio) 
			    test_bit(In_sync, &rdev->flags)) {

				atomic_inc(&rdev->nr_pending);

				rcu_read_unlock();

				atomic_add(s, &rdev->corrected_errors);

				if (sync_page_io(rdev,

						 r10_bio->devs[sl].addr +

						 sect,
@@ -1598,6 +1597,7 @@ static void fix_read_error(conf_t *conf, mddev_t *mddev, r10bio_t *r10_bio) 
					       (unsigned long long)(

						       sect + rdev->data_offset),

					       bdevname(rdev->bdev, b));

					atomic_add(s, &rdev->corrected_errors);

				}



				rdev_dec_pending(rdev, mddev);