Commit cb9ea618 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

tty: make tty_set_operations an inline 



Since commit f34d7a5b (tty: The big operations rework) in 2008,
tty_set_operations() is a simple one-line assignment. There is no reason
for this to be an exported function, hence move it to a header and make
an inline from that.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210723074317.32690-7-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 56ec5880

drivers/tty/tty_io.c

+0 −7
Original line number Diff line number Diff line
@@ -3438,13 +3438,6 @@ void tty_driver_kref_put(struct tty_driver *driver) 
}

EXPORT_SYMBOL(tty_driver_kref_put);



void tty_set_operations(struct tty_driver *driver,

			const struct tty_operations *op)

{

	driver->ops = op;

};

EXPORT_SYMBOL(tty_set_operations);



void put_tty_driver(struct tty_driver *d)

{

	tty_driver_kref_put(d);

include/linux/tty_driver.h

+6 −2
Original line number Diff line number Diff line
@@ -330,8 +330,6 @@ extern struct list_head tty_drivers; 
extern struct tty_driver *__tty_alloc_driver(unsigned int lines,

		struct module *owner, unsigned long flags);

extern void put_tty_driver(struct tty_driver *driver);

extern void tty_set_operations(struct tty_driver *driver,

			const struct tty_operations *op);

extern struct tty_driver *tty_find_polling_driver(char *name, int *line);



extern void tty_driver_kref_put(struct tty_driver *driver);
@@ -346,6 +344,12 @@ static inline struct tty_driver *tty_driver_kref_get(struct tty_driver *d) 
	return d;

}



static inline void tty_set_operations(struct tty_driver *driver,

		const struct tty_operations *op)

{

	driver->ops = op;

}



/* tty driver magic number */

#define TTY_DRIVER_MAGIC		0x5402