Commit cb963a19 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

net: sched: do not allocate a tracker in tcf_exts_init() 



While struct tcf_exts has a net pointer, it is not refcounted
until tcf_exts_get_net() is called.

Fixes: dbdcda63 ("net: sched: add netns refcount tracker to struct tcf_exts")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
Link: https://lore.kernel.org/r/20220110094750.236478-1-eric.dumazet@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 29b3881b

include/net/pkt_cls.h

+3 −1
Original line number Diff line number Diff line
@@ -218,8 +218,10 @@ static inline int tcf_exts_init(struct tcf_exts *exts, struct net *net, 
#ifdef CONFIG_NET_CLS_ACT

	exts->type = 0;

	exts->nr_actions = 0;

	/* Note: we do not own yet a reference on net.

	 * This reference might be taken later from tcf_exts_get_net().

	 */

	exts->net = net;

	netns_tracker_alloc(net, &exts->ns_tracker, GFP_KERNEL);

	exts->actions = kcalloc(TCA_ACT_MAX_PRIO, sizeof(struct tc_action *),

				GFP_KERNEL);

	if (!exts->actions)