Commit cb8fac6d authored Feb 15, 2022 by Alexey Khoroshilov Committed by Trond Myklebust Mar 13, 2022

NFS: remove unneeded check in decode_devicenotify_args()

[You don't often get email from khoroshilov@ispras.ru. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.

]

Overflow check in not needed anymore after we switch to kmalloc_array().

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: a4f743a6 ("NFSv4.1: Convert open-coded array allocation calls to kmalloc_array()")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent 612896ec

fs/nfs/callback_xdr.c

+0 −4

Original line number	Original line	Diff line number	Diff line
	@@ -271,10 +271,6 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp,
	n = ntohl(*p++);		n = ntohl(*p++);
	if (n == 0)		if (n == 0)
	goto out;		goto out;
	if (n > ULONG_MAX / sizeof(*args->devs)) {
	status = htonl(NFS4ERR_BADXDR);
	goto out;
	}

	args->devs = kmalloc_array(n, sizeof(*args->devs), GFP_KERNEL);		args->devs = kmalloc_array(n, sizeof(*args->devs), GFP_KERNEL);
	if (!args->devs) {		if (!args->devs) {