Commit cb8f63b8 authored by Gabriel Knezek's avatar Gabriel Knezek Committed by Bartosz Golaszewski
Browse files

gpiolib: cdev: zero padding during conversion to gpioline_info_changed 



When userspace requests a GPIO v1 line info changed event,
lineinfo_watch_read() populates and returns the gpioline_info_changed
structure. It contains 5 words of padding at the end which are not
initialized before being returned to userspace.

Zero the structure in gpio_v2_line_info_change_to_v1() before populating
its contents.

Fixes: aad95584 ("gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL")
Signed-off-by: default avatarGabriel Knezek <gabeknez@linux.microsoft.com>
Reviewed-by: default avatarKent Gibson <warthog618@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 3093e6cc

drivers/gpio/gpiolib-cdev.c

+1 −0
Original line number Diff line number Diff line
@@ -1880,6 +1880,7 @@ static void gpio_v2_line_info_changed_to_v1( 
		struct gpio_v2_line_info_changed *lic_v2,

		struct gpioline_info_changed *lic_v1)

{

	memset(lic_v1, 0, sizeof(*lic_v1));

	gpio_v2_line_info_to_v1(&lic_v2->info, &lic_v1->info);

	lic_v1->timestamp = lic_v2->timestamp_ns;

	lic_v1->event_type = lic_v2->event_type;