Commit cb690465 authored Nov 19, 2020 by Lee Jones Committed by Dmitry Torokhov Nov 19, 2020

Input: goodix - provide some missing function parameter descriptions

Fixes the following W=1 kernel build warning(s):

drivers/input/touchscreen/goodix.c:569: warning: Function parameter or member 'len' not described in 'goodix_check_cfg'
drivers/input/touchscreen/goodix.c:587: warning: Function parameter or member 'len' not described in 'goodix_send_cfg'
drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'cfg' not described in 'goodix_config_cb'
drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb'
drivers/input/touchscreen/goodix.c:1165: warning: Excess function parameter 'ts' description in 'goodix_config_cb'

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20201112110204.2083435-5-lee.jones@linaro.org

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 7d52613d

drivers/input/touchscreen/goodix.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -564,6 +564,7 @@ static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts)
		*
		* @ts: goodix_ts_data pointer
		* @cfg: firmware config data
		* @len: config data length
		*/
		static int goodix_check_cfg(struct goodix_ts_data ts, const u8 cfg, int len)
		{
		@@ -582,6 +583,7 @@ static int goodix_check_cfg(struct goodix_ts_data ts, const u8 cfg, int len)
		*
		* @ts: goodix_ts_data pointer
		* @cfg: config firmware to write to device
		* @len: config data length
		*/
		static int goodix_send_cfg(struct goodix_ts_data ts, const u8 cfg, int len)
		{
		@@ -1156,6 +1158,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)
		/**
		* goodix_config_cb - Callback to finish device init
		*
		* @cfg: firmware config
		* @ts: our goodix_ts_data pointer
		*
		* request_firmware_wait callback that finishes