Commit cb5da84a authored by Kevin Wang's avatar Kevin Wang Committed by Alex Deucher
Browse files

drm/amd/pm: change return value in aldebaran_get_power_limit() 



v1:
1. change return value to avoid smu driver probe fails when FEATURE_PPT is
not enabled.
2. if FEATURE_PPT is not enabled, set power limit value to 0.

v2:
instead dev_err with dev_warn

Signed-off-by: default avatarKevin Wang <kevin1.wang@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 4a1cac25

drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c

+13 −2
Original line number Diff line number Diff line
@@ -1193,8 +1193,19 @@ static int aldebaran_get_power_limit(struct smu_context *smu, 
	uint32_t power_limit = 0;

	int ret;



	if (!smu_cmn_feature_is_enabled(smu, SMU_FEATURE_PPT_BIT))

		return -EINVAL;

	if (!smu_cmn_feature_is_enabled(smu, SMU_FEATURE_PPT_BIT)) {

		if (current_power_limit)

			*current_power_limit = 0;

		if (default_power_limit)

			*default_power_limit = 0;

		if (max_power_limit)

			*max_power_limit = 0;



		dev_warn(smu->adev->dev,

			"PPT feature is not enabled, power values can't be fetched.");



		return 0;

	}



	/* Valid power data is available only from primary die.

	 * For secondary die show the value as 0.