Commit cb359c63 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Tvrtko Ursulin
Browse files

drm/i915/huc: Fix missing error code in intel_huc_init() 



Smatch warns:
	drivers/gpu/drm/i915/gt/uc/intel_huc.c:388
	    intel_huc_init() warn: missing error code 'err'

When the allocation of VMAs fail: The value of err is zero at this
point and it is passed to PTR_ERR and also finally returning zero which
is success instead of failure.

Fix this by adding the missing error code when VMA allocation fails.

Fixes: 08872cb1 ("drm/i915/mtl/huc: auth HuC via GSC")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230614223646.2583633-1-daniele.ceraolospurio@intel.com


(cherry picked from commit ce432fd3)
Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
parent 21f77351

drivers/gpu/drm/i915/gt/uc/intel_huc.c

+1 −0
Original line number Diff line number Diff line
@@ -384,6 +384,7 @@ int intel_huc_init(struct intel_huc *huc) 


		vma = intel_guc_allocate_vma(&gt->uc.guc, PXP43_HUC_AUTH_INOUT_SIZE * 2);

		if (IS_ERR(vma)) {

			err = PTR_ERR(vma);

			huc_info(huc, "Failed to allocate heci pkt\n");

			goto out;

		}