Commit cb228221 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: 8250: allow disabling of Freescale 16550 compile test 



The SERIAL_8250_FSL option is used to enable a workaround for a
break-detection erratum for Freescale 16550 UARTs in the 8250 driver and
is currently also used to enable support for ACPI enumeration.

It is enabled on PPC, ARM and ARM64 whenever 8250 console support is
enabled (since the quirk is needed for sysrq handling).

Commit b1442c55 ("serial: 8250: extend compile-test coverage")
enabled compile testing of the code in question but did not provide a
means to disable the option when COMPILE_TEST is enabled.

Add a conditional input prompt instead so that SERIAL_8250_FSL is no
longer enabled by default when compile testing while continuing to
always enable the quirk for platforms that may need it.

Fixes: b1442c55 ("serial: 8250: extend compile-test coverage")
Reported-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20210924141232.4419-1-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5816b3e6

drivers/tty/serial/8250/Kconfig

+6 −2
Original line number Diff line number Diff line
@@ -361,9 +361,13 @@ config SERIAL_8250_BCM2835AUX 
	  If unsure, say N.



config SERIAL_8250_FSL

	bool

	bool "Freescale 16550 UART support" if COMPILE_TEST && !(PPC || ARM || ARM64)

	depends on SERIAL_8250_CONSOLE

	default PPC || ARM || ARM64 || COMPILE_TEST

	default PPC || ARM || ARM64

	help

	  Selecting this option enables a workaround for a break-detection

	  erratum for Freescale 16550 UARTs in the 8250 driver. It also

	  enables support for ACPI enumeration.



config SERIAL_8250_DW

	tristate "Support for Synopsys DesignWare 8250 quirks"