Commit caf23895 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans de Goede
Browse files

platform/x86: intel_skl_int3472: Uninitialized variable in skl_int3472_handle_gpio_resources() 



This function returns negative error codes, zero (to indicate that
everything has been completed successfully) and one (to indicate that
more resources need to be handled still).

This code prints an uninitialized error message when the function
returns one which potentially leads to an Oops.

Fixes: 5de691bf ("platform/x86: Add intel_skl_int3472 driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarDaniel Scally <djrscally@gmail.com>
Link: https://lore.kernel.org/r/YNXTkLNtiTDlFlZa@mwanda


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 23dcd749

drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c

+2 −2
Original line number Diff line number Diff line
@@ -286,10 +286,10 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, 
	int3472->ngpios++;

	ACPI_FREE(obj);



	if (ret)

	if (ret < 0)

		return dev_err_probe(int3472->dev, ret, err_msg);



	return 0;

	return ret;

}



static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472)