Commit cae56e17 authored by Daniel Latypov's avatar Daniel Latypov Committed by Shuah Khan
Browse files

kunit: rename print_subtest_{start,end} for clarity (s/subtest/suite) 



These names sound more general than they are.

The _end() function increments a `static int kunit_suite_counter`, so it
can only safely be called on suites, aka top-level subtests.
It would need to have a separate counter for each level of subtest to be
generic enough.

So rename it to make it clear it's only appropriate for suites.

Signed-off-by: default avatarDaniel Latypov <dlatypov@google.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 9bf2eed9

lib/kunit/test.c

+4 −4
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ size_t kunit_suite_num_test_cases(struct kunit_suite *suite) 
}

EXPORT_SYMBOL_GPL(kunit_suite_num_test_cases);



static void kunit_print_subtest_start(struct kunit_suite *suite)

static void kunit_print_suite_start(struct kunit_suite *suite)

{

	kunit_log(KERN_INFO, suite, KUNIT_SUBTEST_INDENT "# Subtest: %s",

		  suite->name);
@@ -192,7 +192,7 @@ EXPORT_SYMBOL_GPL(kunit_suite_has_succeeded); 


static size_t kunit_suite_counter = 1;



static void kunit_print_subtest_end(struct kunit_suite *suite)

static void kunit_print_suite_end(struct kunit_suite *suite)

{

	kunit_print_ok_not_ok((void *)suite, false,

			      kunit_suite_has_succeeded(suite),
@@ -498,7 +498,7 @@ int kunit_run_tests(struct kunit_suite *suite) 
	struct kunit_result_stats suite_stats = { 0 };

	struct kunit_result_stats total_stats = { 0 };



	kunit_print_subtest_start(suite);

	kunit_print_suite_start(suite);



	kunit_suite_for_each_test_case(suite, test_case) {

		struct kunit test = { .param_value = NULL, .param_index = 0 };
@@ -552,7 +552,7 @@ int kunit_run_tests(struct kunit_suite *suite) 
	}



	kunit_print_suite_stats(suite, suite_stats, total_stats);

	kunit_print_subtest_end(suite);

	kunit_print_suite_end(suite);



	return 0;

}