Commit cae253d6 authored by Bastien Nocera's avatar Bastien Nocera Committed by Benjamin Tissoires
Browse files

Revert "HID: logitech-hidpp: add a module parameter to keep firmware gestures" 



Now that we're in 2022, and the majority of desktop environments can and
should support touchpad gestures through libinput, remove the legacy
module parameter that made it possible to use gestures implemented in
firmware.

This will eventually allow simplifying the driver's initialisation code.

This reverts commit 9188dbae.

Signed-off-by: default avatarBastien Nocera <hadess@hadess.net>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20221220154345.474596-1-hadess@hadess.net
parent 719acb4d

drivers/hid/hid-logitech-hidpp.c

+0 −10
Original line number Diff line number Diff line
@@ -31,11 +31,6 @@ MODULE_LICENSE("GPL"); 
MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@gmail.com>");

MODULE_AUTHOR("Nestor Lopez Casado <nlopezcasad@logitech.com>");



static bool disable_raw_mode;

module_param(disable_raw_mode, bool, 0644);

MODULE_PARM_DESC(disable_raw_mode,

	"Disable Raw mode reporting for touchpads and keep firmware gestures.");



static bool disable_tap_to_click;

module_param(disable_tap_to_click, bool, 0644);

MODULE_PARM_DESC(disable_tap_to_click,
@@ -4141,11 +4136,6 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	    hidpp_application_equals(hdev, HID_GD_KEYBOARD))

		hidpp->quirks |= HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS;



	if (disable_raw_mode) {

		hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP;

		hidpp->quirks &= ~HIDPP_QUIRK_NO_HIDINPUT;

	}



	if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {

		ret = wtp_allocate(hdev, id);

		if (ret)