Commit caa0578c authored by Dinghao Liu's avatar Dinghao Liu Committed by David S. Miller
Browse files

ptp: ocp: Fix error handling in ptp_ocp_device_init 



When device_add() fails, ptp_ocp_dev_release() will be called
after put_device(). Therefore, it seems that the
ptp_ocp_dev_release() before put_device() is redundant.

Fixes: 773bda96 ("ptp: ocp: Expose various resources on the timecard.")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: default avatarVadim Feodrenko <vadim.fedorenko@linux.dev>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c889a99a

drivers/ptp/ptp_ocp.c

+0 −1
Original line number Diff line number Diff line
@@ -3998,7 +3998,6 @@ ptp_ocp_device_init(struct ptp_ocp *bp, struct pci_dev *pdev) 
	return 0;



out:

	ptp_ocp_dev_release(&bp->dev);

	put_device(&bp->dev);

	return err;

}