Unverified Commit ca9b8f56 authored by Yang Yingliang's avatar Yang Yingliang Committed by Mark Brown
Browse files

spi: bcm-qspi: Fix missing clk_disable_unprepare() on error in bcm_qspi_probe() 



Fix the missing clk_disable_unprepare() before return
from bcm_qspi_probe() in the error handling case.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20211018073413.2029081-1-yangyingliang@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3340ec49

drivers/spi/spi-bcm-qspi.c

+3 −2
Original line number Diff line number Diff line
@@ -1602,7 +1602,7 @@ int bcm_qspi_probe(struct platform_device *pdev, 
					       &qspi->dev_ids[val]);

			if (ret < 0) {

				dev_err(&pdev->dev, "IRQ %s not found\n", name);

				goto qspi_probe_err;

				goto qspi_unprepare_err;

			}



			qspi->dev_ids[val].dev = qspi;
@@ -1617,7 +1617,7 @@ int bcm_qspi_probe(struct platform_device *pdev, 
	if (!num_ints) {

		dev_err(&pdev->dev, "no IRQs registered, cannot init driver\n");

		ret = -EINVAL;

		goto qspi_probe_err;

		goto qspi_unprepare_err;

	}



	bcm_qspi_hw_init(qspi);
@@ -1641,6 +1641,7 @@ int bcm_qspi_probe(struct platform_device *pdev, 


qspi_reg_err:

	bcm_qspi_hw_uninit(qspi);

qspi_unprepare_err:

	clk_disable_unprepare(qspi->clk);

qspi_probe_err:

	kfree(qspi->dev_ids);