Commit ca92b93d authored by Yangtao Li's avatar Yangtao Li Committed by Martin Schwidefsky
Browse files

s390: convert to DEFINE_SHOW_ATTRIBUTE 



Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Signed-off-by: default avatarSebastian Ott <sebott@linux.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 5b39fc04

drivers/s390/block/dasd.c

+1 −14
Original line number Diff line number Diff line
@@ -1192,20 +1192,7 @@ static int dasd_hosts_show(struct seq_file *m, void *v) 
	return rc;

}



static int dasd_hosts_open(struct inode *inode, struct file *file)

{

	struct dasd_device *device = inode->i_private;



	return single_open(file, dasd_hosts_show, device);

}



static const struct file_operations dasd_hosts_fops = {

	.owner		= THIS_MODULE,

	.open		= dasd_hosts_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(dasd_hosts);



static void dasd_hosts_exit(struct dasd_device *device)

{

drivers/s390/cio/qdio_debug.c

+2 −14
Original line number Diff line number Diff line
@@ -190,19 +190,7 @@ static int qstat_show(struct seq_file *m, void *v) 
	return 0;

}



static int qstat_seq_open(struct inode *inode, struct file *filp)

{

	return single_open(filp, qstat_show,

			   file_inode(filp)->i_private);

}



static const struct file_operations debugfs_fops = {

	.owner	 = THIS_MODULE,

	.open	 = qstat_seq_open,

	.read	 = seq_read,

	.llseek  = seq_lseek,

	.release = single_release,

};

DEFINE_SHOW_ATTRIBUTE(qstat);



static char *qperf_names[] = {

	"Assumed adapter interrupts",
@@ -306,7 +294,7 @@ static void setup_debugfs_entry(struct qdio_q *q) 
		 q->is_input_q ? "input" : "output",

		 q->nr);

	q->debugfs_q = debugfs_create_file(name, S_IFREG | S_IRUGO | S_IWUSR,

				q->irq_ptr->debugfs_dev, q, &debugfs_fops);

				q->irq_ptr->debugfs_dev, q, &qstat_fops);

	if (IS_ERR(q->debugfs_q))

		q->debugfs_q = NULL;

}