Commit ca88eeb3 authored Jan 10, 2023 by Luka Guzenko Committed by Takashi Iwai Jan 12, 2023

ALSA: hda/realtek: Enable mute/micmute LEDs on HP Spectre x360 13-aw0xxx



The HP Spectre x360 13-aw0xxx devices use the ALC285 codec with GPIO 0x04
controlling the micmute LED and COEF 0x0b index 8 controlling the mute LED.
A quirk was added to make these work as well as a fixup.

Signed-off-by: Luka Guzenko <l.guzenko@web.de>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230110202514.2792-1-l.guzenko@web.de


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent de1ccb9e

sound/pci/hda/patch_realtek.c

+23 −0

Original line number	Original line	Diff line number	Diff line
	@@ -4646,6 +4646,16 @@ static void alc285_fixup_hp_coef_micmute_led(struct hda_codec *codec,
	}		}
	}		}

			static void alc285_fixup_hp_gpio_micmute_led(struct hda_codec *codec,
			const struct hda_fixup *fix, int action)
			{
			struct alc_spec *spec = codec->spec;

			if (action == HDA_FIXUP_ACT_PRE_PROBE)
			spec->micmute_led_polarity = 1;
			alc_fixup_hp_gpio_led(codec, action, 0, 0x04);
			}

	static void alc236_fixup_hp_coef_micmute_led(struct hda_codec *codec,		static void alc236_fixup_hp_coef_micmute_led(struct hda_codec *codec,
	const struct hda_fixup *fix, int action)		const struct hda_fixup *fix, int action)
	{		{
	@@ -4667,6 +4677,13 @@ static void alc285_fixup_hp_mute_led(struct hda_codec *codec,
	alc285_fixup_hp_coef_micmute_led(codec, fix, action);		alc285_fixup_hp_coef_micmute_led(codec, fix, action);
	}		}

			static void alc285_fixup_hp_spectre_x360_mute_led(struct hda_codec *codec,
			const struct hda_fixup *fix, int action)
			{
			alc285_fixup_hp_mute_led_coefbit(codec, fix, action);
			alc285_fixup_hp_gpio_micmute_led(codec, fix, action);
			}

	static void alc236_fixup_hp_mute_led(struct hda_codec *codec,		static void alc236_fixup_hp_mute_led(struct hda_codec *codec,
	const struct hda_fixup *fix, int action)		const struct hda_fixup *fix, int action)
	{		{
	@@ -7108,6 +7125,7 @@ enum {
	ALC285_FIXUP_ASUS_G533Z_PINS,		ALC285_FIXUP_ASUS_G533Z_PINS,
	ALC285_FIXUP_HP_GPIO_LED,		ALC285_FIXUP_HP_GPIO_LED,
	ALC285_FIXUP_HP_MUTE_LED,		ALC285_FIXUP_HP_MUTE_LED,
			ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED,
	ALC236_FIXUP_HP_GPIO_LED,		ALC236_FIXUP_HP_GPIO_LED,
	ALC236_FIXUP_HP_MUTE_LED,		ALC236_FIXUP_HP_MUTE_LED,
	ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF,		ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF,
	@@ -8488,6 +8506,10 @@ static const struct hda_fixup alc269_fixups[] = {
	.type = HDA_FIXUP_FUNC,		.type = HDA_FIXUP_FUNC,
	.v.func = alc285_fixup_hp_mute_led,		.v.func = alc285_fixup_hp_mute_led,
	},		},
			[ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED] = {
			.type = HDA_FIXUP_FUNC,
			.v.func = alc285_fixup_hp_spectre_x360_mute_led,
			},
	[ALC236_FIXUP_HP_GPIO_LED] = {		[ALC236_FIXUP_HP_GPIO_LED] = {
	.type = HDA_FIXUP_FUNC,		.type = HDA_FIXUP_FUNC,
	.v.func = alc236_fixup_hp_gpio_led,		.v.func = alc236_fixup_hp_gpio_led,
	@@ -9330,6 +9352,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
	SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),		SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
	SND_PCI_QUIRK(0x103c, 0x86e7, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),		SND_PCI_QUIRK(0x103c, 0x86e7, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),
	SND_PCI_QUIRK(0x103c, 0x86e8, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),		SND_PCI_QUIRK(0x103c, 0x86e8, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),
			SND_PCI_QUIRK(0x103c, 0x86f9, "HP Spectre x360 13-aw0xxx", ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED),
	SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),		SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
	SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),		SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
	SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),		SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),