Commit ca763340 authored by Ioana Ciornei's avatar Ioana Ciornei Committed by Jakub Kicinski
Browse files

dpaa2-mac: remove an unnecessary check 



The dpaa2-eth driver has phylink integration only if the connected dpmac
object is in TYPE_PHY (aka the PCS/PHY etc link status is managed by
Linux instead of the firmware). The check is thus unnecessary because
the code path that reaches the .mac_link_up() callback is only with
TYPE_PHY dpmac objects.

Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 47325da2

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

+19 −24
Original line number Diff line number Diff line
@@ -174,10 +174,6 @@ static void dpaa2_mac_link_up(struct phylink_config *config, 


	dpmac_state->up = 1;



	if (mac->if_link_type == DPMAC_LINK_TYPE_PHY) {

		/* If the DPMAC is configured for PHY mode, we need

		 * to pass the link parameters to the MC firmware.

		 */

	dpmac_state->rate = speed;



	if (duplex == DUPLEX_HALF)
@@ -197,7 +193,6 @@ static void dpaa2_mac_link_up(struct phylink_config *config, 
		dpmac_state->options |= DPMAC_LINK_OPT_ASYM_PAUSE;

	else

		dpmac_state->options &= ~DPMAC_LINK_OPT_ASYM_PAUSE;

	}



	err = dpmac_set_link_state(mac->mc_io, 0,

				   mac->mc_dev->mc_handle, dpmac_state);