Commit ca6a77eb authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bartosz Golaszewski
Browse files

gpio: pca953x: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 4e7ed696

drivers/gpio/gpio-pca953x.c

+3 −6
Original line number Diff line number Diff line
@@ -1000,12 +1000,9 @@ static int pca953x_probe(struct i2c_client *client, 
	chip->client = client;



	reg = devm_regulator_get(&client->dev, "vcc");

	if (IS_ERR(reg)) {

		ret = PTR_ERR(reg);

		if (ret != -EPROBE_DEFER)

			dev_err(&client->dev, "reg get err: %d\n", ret);

		return ret;

	}

	if (IS_ERR(reg))

		return dev_err_probe(&client->dev, PTR_ERR(reg), "reg get err\n");



	ret = regulator_enable(reg);

	if (ret) {

		dev_err(&client->dev, "reg en err: %d\n", ret);