Commit ca5f7256 authored by Mike Marciniszyn's avatar Mike Marciniszyn Committed by Jason Gunthorpe
Browse files

IB/hfi1: Use kzalloc() for mmu_rb_handler allocation 

The code currently assumes that the mmu_notifier struct
embedded in mmu_rb_handler only contains two fields.

There are now extra fields:

struct mmu_notifier {
        struct hlist_node hlist;
        const struct mmu_notifier_ops *ops;
        struct mm_struct *mm;
        struct rcu_head rcu;
        unsigned int users;
};

Given that there in no init for the mmu_notifier, a kzalloc() should
be used to insure that any newly added fields are given a predictable
initial value of zero.

Fixes: 06e0ffa6 ("IB/hfi1: Re-factor MMU notification code")
Link: https://lore.kernel.org/r/1617026056-50483-9-git-send-email-dennis.dalessandro@cornelisnetworks.com


Reviewed-by: default avatarAdam Goldman <adam.goldman@intel.com>
Signed-off-by: default avatarMike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 6b13215d

drivers/infiniband/hw/hfi1/mmu_rb.c

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ int hfi1_mmu_rb_register(void *ops_arg, 
	struct mmu_rb_handler *h;

	int ret;



	h = kmalloc(sizeof(*h), GFP_KERNEL);

	h = kzalloc(sizeof(*h), GFP_KERNEL);

	if (!h)

		return -ENOMEM;