Commit ca5cd355 authored by John Fastabend's avatar John Fastabend Committed by Daniel Borkmann
Browse files

bpf, selftests: use :: 1 for localhost in tcp_server.py 



Using localhost requires the host to have a /etc/hosts file with that
specific line in it. By default my dev box did not, they used
ip6-localhost, so the test was failing. To fix remove the need for any
/etc/hosts and use ::1.

I could just add the line, but this seems easier.

Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarSong Liu <songliubraving@fb.com>
Acked-by: default avatarAndrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/159594714197.21431.10113693935099326445.stgit@john-Precision-5820-Tower
parent 3c4f850e

tools/testing/selftests/bpf/tcp_client.py

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ serverPort = int(sys.argv[1]) 
# create active socket

sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)

try:

    sock.connect(('localhost', serverPort))

    sock.connect(('::1', serverPort))

except socket.error as e:

    sys.exit(1)

tools/testing/selftests/bpf/tcp_server.py

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ serverSocket = None 
# create passive socket

serverSocket = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)



try: serverSocket.bind(('localhost', 0))

try: serverSocket.bind(('::1', 0))

except socket.error as msg:

    print('bind fails: ' + str(msg))

tools/testing/selftests/bpf/test_netcnt.c

+2 −2
Original line number Diff line number Diff line
@@ -82,9 +82,9 @@ int main(int argc, char **argv) 
	}



	if (system("which ping6 &>/dev/null") == 0)

		assert(!system("ping6 localhost -c 10000 -f -q > /dev/null"));

		assert(!system("ping6 ::1 -c 10000 -f -q > /dev/null"));

	else

		assert(!system("ping -6 localhost -c 10000 -f -q > /dev/null"));

		assert(!system("ping -6 ::1 -c 10000 -f -q > /dev/null"));



	if (bpf_prog_query(cgroup_fd, BPF_CGROUP_INET_EGRESS, 0, NULL, NULL,

			   &prog_cnt)) {