Commit ca538531 authored May 12, 2022 by Guenter Roeck

hwmon: (sl28cpld-hwmon) Use HWMON_CHANNEL_INFO macro



The HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood
of errors, and makes the code easier to read.

The conversion was done automatically with coccinelle. The semantic patch
used to make this change is as follows.

@s@
identifier i,j,ty;
@@

-struct hwmon_channel_info j = {
-       .type = ty,
-       .config = i,
-};

@r@
initializer list elements;
identifier s.i;
@@

-u32 i[] = {
-  elements,
-  0
-};

@script:ocaml t@
ty << s.ty;
elements << r.elements;
shorter;
elems;
@@

shorter :=
   make_ident (List.hd(List.rev (Str.split (Str.regexp "_") ty)));
elems :=
   make_ident
    (String.concat ","
     (List.map (fun x -> Printf.sprintf "\n\t\t\t   %s" x)
       (Str.split (Str.regexp " , ") elements)))

@@
identifier s.j,t.shorter;
identifier t.elems;
@@

- &j
+ HWMON_CHANNEL_INFO(shorter,elems)

This patch does not introduce functional changes. Many thanks to
Julia Lawall for providing the coccinelle script.

Cc: Michael Walle <michael@walle.cc>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 7282d2ae

drivers/hwmon/sl28cpld-hwmon.c

+1 −11

Original line number	Diff line number	Diff line
		@@ -67,18 +67,8 @@ static int sl28cpld_hwmon_read(struct device *dev,
		return 0;
		}

		static const u32 sl28cpld_hwmon_fan_config[] = {
		HWMON_F_INPUT,
		0
		};

		static const struct hwmon_channel_info sl28cpld_hwmon_fan = {
		.type = hwmon_fan,
		.config = sl28cpld_hwmon_fan_config,
		};

		static const struct hwmon_channel_info *sl28cpld_hwmon_info[] = {
		&sl28cpld_hwmon_fan,
		HWMON_CHANNEL_INFO(fan, HWMON_F_INPUT),
		NULL
		};