Commit ca4c72c0 authored by Pierre-Yves MORDRET's avatar Pierre-Yves MORDRET Committed by Vinod Koul
Browse files

dmaengine: stm32-dma: check FIFO error interrupt enable 



For avoiding false FIFO detection, check FIFO Error interrupt is
enabled prior raising any errors.
This will prevent having spurious FIFO error where it shouldn't.

Signed-off-by: default avatarPierre-Yves MORDRET <pierre-yves.mordret@st.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 906b40b2

drivers/dma/stm32-dma.c

+8 −5
Original line number Diff line number Diff line
@@ -641,12 +641,13 @@ static irqreturn_t stm32_dma_chan_irq(int irq, void *devid) 
{

	struct stm32_dma_chan *chan = devid;

	struct stm32_dma_device *dmadev = stm32_dma_get_dev(chan);

	u32 status, scr;

	u32 status, scr, sfcr;



	spin_lock(&chan->vchan.lock);



	status = stm32_dma_irq_status(chan);

	scr = stm32_dma_read(dmadev, STM32_DMA_SCR(chan->id));

	sfcr = stm32_dma_read(dmadev, STM32_DMA_SFCR(chan->id));



	if (status & STM32_DMA_TCI) {

		stm32_dma_irq_clear(chan, STM32_DMA_TCI);
@@ -661,11 +662,13 @@ static irqreturn_t stm32_dma_chan_irq(int irq, void *devid) 
	if (status & STM32_DMA_FEI) {

		stm32_dma_irq_clear(chan, STM32_DMA_FEI);

		status &= ~STM32_DMA_FEI;

		if (sfcr & STM32_DMA_SFCR_FEIE) {

			if (!(scr & STM32_DMA_SCR_EN))

				dev_err(chan2dev(chan), "FIFO Error\n");

			else

				dev_dbg(chan2dev(chan), "FIFO over/underrun\n");

		}

	}

	if (status) {

		stm32_dma_irq_clear(chan, status);

		dev_err(chan2dev(chan), "DMA error: status=0x%08x\n", status);