Commit ca2943fe authored May 29, 2023 by Srinivasan Shanmugam Committed by Alex Deucher Jun 09, 2023

drm/amdgpu: Fix missing parameter desc for 'xcc_id' in gfx_v7_0.c & amdgpu_rlc.c

Fix these warnings by adding 'xcc_id' arguments.

gcc with W=1
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1557: warning: Function parameter or member 'xcc_id' not described in 'gfx_v7_0_select_se_sh'
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:38: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_gfx_rlc_enter_safe_mode'
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:62: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_gfx_rlc_exit_safe_mode'

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent c22b0440

drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -31,6 +31,7 @@
		* amdgpu_gfx_rlc_enter_safe_mode - Set RLC into safe mode
		*
		* @adev: amdgpu_device pointer
		* @xcc_id: xcc accelerated compute core id
		*
		* Set RLC enter into safe mode if RLC is enabled and haven't in safe mode.
		*/
		@@ -55,6 +56,7 @@ void amdgpu_gfx_rlc_enter_safe_mode(struct amdgpu_device *adev, int xcc_id)
		* amdgpu_gfx_rlc_exit_safe_mode - Set RLC out of safe mode
		*
		* @adev: amdgpu_device pointer
		* @xcc_id: xcc accelerated compute core id
		*
		* Set RLC exit safe mode if RLC is enabled and have entered into safe mode.
		*/

drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1548,7 +1548,7 @@ static void gfx_v7_0_tiling_mode_table_init(struct amdgpu_device *adev)
		* @sh_num: sh block to address
		* @instance: Certain registers are instanced per SE or SH.
		* 0xffffffff means broadcast to all SEs or SHs (CIK).
		*
		* @xcc_id: xcc accelerated compute core id
		* Select which SE, SH combinations to address.
		*/
		static void gfx_v7_0_select_se_sh(struct amdgpu_device *adev,