Commit ca0e8940 authored by Wei Yongjun's avatar Wei Yongjun Committed by Bjorn Andersson
Browse files

remoteproc: qcom: wcss: Fix wrong pointer passed to PTR_ERR() 



PTR_ERR should access the value just tested by IS_ERR, otherwise
the wrong error code will be returned.

This commit fix it by return 'ret' directly.

Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 0af65b9b ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210326024741.841267-1-weiyongjun1@huawei.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 3fdba9d2

drivers/remoteproc/qcom_q6v5_wcss.c

+1 −1
Original line number Diff line number Diff line
@@ -972,7 +972,7 @@ static int q6v5_wcss_init_clock(struct q6v5_wcss *wcss) 
		ret = PTR_ERR(wcss->qdsp6ss_axim_cbcr);

		if (ret != -EPROBE_DEFER)

			dev_err(wcss->dev, "failed to get axim cbcr clk\n");

		return PTR_ERR(wcss->qdsp6ss_abhm_cbcr);

		return ret;

	}



	wcss->lcc_bcr_sleep = devm_clk_get(wcss->dev, "lcc_bcr_sleep");