Unverified Commit ca03dba3 authored by Julia Lawall's avatar Julia Lawall Committed by Mark Brown
Browse files

spi/topcliff-pch: drop double zeroing 

sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
  (n,sizeof(*x),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Link: https://lore.kernel.org/r/1600601186-7420-12-git-send-email-Julia.Lawall@inria.fr


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bc3d9243

drivers/spi/spi-topcliff-pch.c

+2 −2
Original line number Diff line number Diff line
@@ -1002,7 +1002,7 @@ static void pch_spi_handle_dma(struct pch_spi_data *data, int *bpw) 
	spin_unlock_irqrestore(&data->lock, flags);



	/* RX */

	dma->sg_rx_p = kcalloc(num, sizeof(*dma->sg_rx_p), GFP_ATOMIC);

	dma->sg_rx_p = kmalloc_array(num, sizeof(*dma->sg_rx_p), GFP_ATOMIC);

	if (!dma->sg_rx_p)

		return;
@@ -1065,7 +1065,7 @@ static void pch_spi_handle_dma(struct pch_spi_data *data, int *bpw) 
		head = 0;

	}



	dma->sg_tx_p = kcalloc(num, sizeof(*dma->sg_tx_p), GFP_ATOMIC);

	dma->sg_tx_p = kmalloc_array(num, sizeof(*dma->sg_tx_p), GFP_ATOMIC);

	if (!dma->sg_tx_p)

		return;