Unverified Commit c9ef0fee authored by Jacob Keller's avatar Jacob Keller Committed by Mark Brown
Browse files

ASoC: Intel: avs: Use struct_size for struct avs_modcfg_ext size 



The struct avs_modcfg_ext structure has a flexible array member for the
pin_fmts array, and the size should be calculated using struct_size to
prevent the potential for overflow with the allocation.

Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: default avatar"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20230303180457.2457069-1-jacob.e.keller@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fe15c26e

sound/soc/intel/avs/path.c

+1 −1
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ static int avs_modext_create(struct avs_dev *adev, struct avs_path_module *mod) 
	int ret, i;



	num_pins = tcfg->generic.num_input_pins + tcfg->generic.num_output_pins;

	cfg_size = sizeof(*cfg) + sizeof(*cfg->pin_fmts) * num_pins;

	cfg_size = struct_size(cfg, pin_fmts, num_pins);



	cfg = kzalloc(cfg_size, GFP_KERNEL);

	if (!cfg)