Commit c9d84681 authored by Liang He's avatar Liang He Committed by Sebastian Reichel
Browse files

power: supply: olpc_battery: Hold the reference returned by of_find_compatible_node 



In olpc_battery_probe(), we should hold the reference returned by
of_find_compatible_node() and use it to call of_node_put() for
refcount balance.

Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 38d45444

drivers/power/supply/olpc_battery.c

+4 −1
Original line number Diff line number Diff line
@@ -635,6 +635,7 @@ static int olpc_battery_probe(struct platform_device *pdev) 
	struct power_supply_config bat_psy_cfg = {};

	struct power_supply_config ac_psy_cfg = {};

	struct olpc_battery_data *data;

	struct device_node *np;

	uint8_t status;

	uint8_t ecver;

	int ret;
@@ -649,7 +650,9 @@ static int olpc_battery_probe(struct platform_device *pdev) 
	if (ret)

		return ret;



	if (of_find_compatible_node(NULL, NULL, "olpc,xo1.75-ec")) {

	np = of_find_compatible_node(NULL, NULL, "olpc,xo1.75-ec");

	if (np) {

		of_node_put(np);

		/* XO 1.75 */

		data->new_proto = true;

		data->little_endian = true;