Commit c9c256a8 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Ulf Hansson
Browse files

mmc: sdhci-sprd: Fix some resource leaks in the remove function 



'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of
'mmc_remove_host()' and 'mmc_free_host()'.

This avoids some resource leaks, is more in line with the error handling
path of the probe function, and is more consistent with other drivers.

Fixes: fb8bd90f ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarOrson Zhai <orson.zhai@gmail.com>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20201217204236.163446-1-christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 5d15cbf6

drivers/mmc/host/sdhci-sprd.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -708,14 +708,14 @@ static int sdhci_sprd_remove(struct platform_device *pdev) 
{

{

	struct sdhci_host *host = platform_get_drvdata(pdev);

	struct sdhci_host *host = platform_get_drvdata(pdev);

	struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);

	struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);

	struct mmc_host *mmc = host->mmc;





	mmc_remove_host(mmc);

	sdhci_remove_host(host, 0);



	clk_disable_unprepare(sprd_host->clk_sdio);

	clk_disable_unprepare(sprd_host->clk_sdio);

	clk_disable_unprepare(sprd_host->clk_enable);

	clk_disable_unprepare(sprd_host->clk_enable);

	clk_disable_unprepare(sprd_host->clk_2x_enable);

	clk_disable_unprepare(sprd_host->clk_2x_enable);





	mmc_free_host(mmc);

	sdhci_pltfm_free(pdev);





	return 0;

	return 0;

}

}