Commit c9ac080b authored by Julia Lawall's avatar Julia Lawall Committed by Jakub Kicinski
Browse files

net: moxa: use GFP_KERNEL 



Platform_driver probe functions aren't called with locks
held and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.

Problem found with Coccinelle.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Link: https://lore.kernel.org/r/20220210204223.104181-1-Julia.Lawall@inria.fr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5f7dc7d4

drivers/net/ethernet/moxa/moxart_ether.c

+2 −2
Original line number Diff line number Diff line
@@ -510,14 +510,14 @@ static int moxart_mac_probe(struct platform_device *pdev) 
	}



	priv->tx_buf_base = kmalloc_array(priv->tx_buf_size, TX_DESC_NUM,

					  GFP_ATOMIC);

					  GFP_KERNEL);

	if (!priv->tx_buf_base) {

		ret = -ENOMEM;

		goto init_fail;

	}



	priv->rx_buf_base = kmalloc_array(priv->rx_buf_size, RX_DESC_NUM,

					  GFP_ATOMIC);

					  GFP_KERNEL);

	if (!priv->rx_buf_base) {

		ret = -ENOMEM;

		goto init_fail;