Commit c9664839 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Dave Hansen
Browse files

x86: Avoid missing-prototype warnings for doublefault code 



Two functions in the 32-bit doublefault code are lacking a prototype:

arch/x86/kernel/doublefault_32.c:23:36: error: no previous prototype for 'doublefault_shim' [-Werror=missing-prototypes]
   23 | asmlinkage noinstr void __noreturn doublefault_shim(void)
      |                                    ^~~~~~~~~~~~~~~~
arch/x86/kernel/doublefault_32.c:114:6: error: no previous prototype for 'doublefault_init_cpu_tss' [-Werror=missing-prototypes]
  114 | void doublefault_init_cpu_tss(void)

The first one is only called from assembler, while the second one is
declared in doublefault.h, but this file is not included.

Include the header file and add the other declaration there as well.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: default avatarAlexander Lobakin <aleksander.lobakin@intel.com>
Link: https://lore.kernel.org/all/20230516193549.544673-8-arnd%40kernel.org
parent 16db7e9c

arch/x86/include/asm/doublefault.h

+4 −0
Original line number Diff line number Diff line
@@ -2,6 +2,8 @@ 
#ifndef _ASM_X86_DOUBLEFAULT_H

#define _ASM_X86_DOUBLEFAULT_H



#include <linux/linkage.h>



#ifdef CONFIG_X86_32

extern void doublefault_init_cpu_tss(void);

#else
@@ -10,4 +12,6 @@ static inline void doublefault_init_cpu_tss(void) 
}

#endif



asmlinkage void __noreturn doublefault_shim(void);



#endif /* _ASM_X86_DOUBLEFAULT_H */

arch/x86/kernel/doublefault_32.c

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#include <asm/processor.h>

#include <asm/desc.h>

#include <asm/traps.h>

#include <asm/doublefault.h>



#define ptr_ok(x) ((x) > PAGE_OFFSET && (x) < PAGE_OFFSET + MAXMEM)