Commit c95ce3a2 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

topology: Fix up build warning in topology_is_visible() 



Commit aa63a74d ("topology/sysfs: Hide PPIN on systems that do not
support it.") caused a build warning on some configurations:

drivers/base/topology.c: In function 'topology_is_visible':
drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
  158 |         struct device *dev = kobj_to_dev(kobj);

Fix this up by getting rid of the variable entirely.

Fixes: aa63a74d ("topology/sysfs: Hide PPIN on systems that do not support it.")
Cc: Tony Luck <tony.luck@intel.com>
Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/r/20220422062653.3899972-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1dc9f1a6

drivers/base/topology.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -155,9 +155,7 @@ static struct attribute *default_attrs[] = { 
static umode_t topology_is_visible(struct kobject *kobj,

static umode_t topology_is_visible(struct kobject *kobj,

				   struct attribute *attr, int unused)

				   struct attribute *attr, int unused)

{

{

	struct device *dev = kobj_to_dev(kobj);

	if (attr == &dev_attr_ppin.attr && !topology_ppin(kobj_to_dev(kobj)->id))



	if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))

		return 0;

		return 0;





	return attr->mode;

	return attr->mode;