Commit c954cd7a authored by Thierry Reding's avatar Thierry Reding
Browse files

soc/tegra: pmc: Use devm_clk_notifier_register() 



Move to the device-managed version of clk_notifier_register() to remove
the need for manual cleanup. This fixes a potential issue where the
clock notifier would stick around after the driver fails to probe at a
later point.

Reviewed-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent bae9fb2d

drivers/soc/tegra/pmc.c

+2 −2
Original line number Diff line number Diff line
@@ -2992,7 +2992,8 @@ static int tegra_pmc_probe(struct platform_device *pdev) 
	 */

	if (pmc->clk) {

		pmc->clk_nb.notifier_call = tegra_pmc_clk_notify_cb;

		err = clk_notifier_register(pmc->clk, &pmc->clk_nb);

		err = devm_clk_notifier_register(&pdev->dev, pmc->clk,

						 &pmc->clk_nb);

		if (err) {

			dev_err(&pdev->dev,

				"failed to register clk notifier\n");
@@ -3052,7 +3053,6 @@ static int tegra_pmc_probe(struct platform_device *pdev) 
cleanup_sysfs:

	device_remove_file(&pdev->dev, &dev_attr_reset_reason);

	device_remove_file(&pdev->dev, &dev_attr_reset_level);

	clk_notifier_unregister(pmc->clk, &pmc->clk_nb);



	return err;

}