Commit c9538831 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Jason Gunthorpe
Browse files

RDMA/irdma: Change the returned type to void 

Since the function irdma_sc_parse_fpm_commit_buf always returns 0, remove
the returned value check and change the returned type to void.

Fixes: 3f49d684 ("RDMA/irdma: Implement HW Admin Queue OPs")
Link: https://lore.kernel.org/r/20210708064752.797520-1-yanjun.zhu@linux.dev


Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: default avatarMajd Dibbiny <majd@nvidia.com>
Acked-by: default avatarTatyana Nikolova <tatyana.e.nikolova@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 514305ee

drivers/infiniband/hw/irdma/ctrl.c

+4 −5
Original line number Diff line number Diff line
@@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct irdma_sc_dev *dev, __le64 *buf, 
 * parses fpm commit info and copy base value

 * of hmc objects in hmc_info

 */

static enum irdma_status_code

static void

irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,

			      struct irdma_hmc_obj_info *info, u32 *sd)

{
@@ -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf, 
	else

		*sd = (u32)(size >> 21);



	return 0;

}



/**
@@ -4434,7 +4433,7 @@ static enum irdma_status_code irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev, 
	ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info->hmc_fn_id,

					   &commit_fpm_mem, true, wait_type);

	if (!ret_code)

		ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,

		irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,

					      hmc_info->hmc_obj,

					      &hmc_info->sd_table.sd_cnt);

	print_hex_dump_debug("HMC: COMMIT FPM BUFFER", DUMP_PREFIX_OFFSET, 16,