Commit c95310e1 authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: parsers: qcom: Fix error condition 



qcom_smem_get() does not return NULL, and even if it did, the NULL
condition is usually not an error but a success condition and should
not trigger an error trace.

Let's replace IS_ERR_OR_NULL() by IS_ERR().

This fixes the following smatch warning:
drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR'

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 803eb124 ("mtd: parsers: Add Qcom SMEM parser")
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210303084634.12796-1-miquel.raynal@bootlin.com
parent 2d751203

drivers/mtd/parsers/qcomsmempart.c

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ static int parse_qcomsmem_part(struct mtd_info *mtd, 
	 * complete partition table

	 */

	ptable = qcom_smem_get(SMEM_APPS, SMEM_AARM_PARTITION_TABLE, &len);

	if (IS_ERR_OR_NULL(ptable)) {

	if (IS_ERR(ptable)) {

		pr_err("Error reading partition table\n");

		return PTR_ERR(ptable);

	}