Commit c901a8ca authored by Rob Clark's avatar Rob Clark
Browse files

drm/msm: Remove exclusive-fence hack



The workaround was initially necessary due to dma_resv having only a
single exclusive fence slot, yet whe don't necessarily know what order
the gpu scheduler will schedule jobs.  Unfortunately this workaround
also has the result of forcing implicit sync, even when userspace does
not want it.

However, since commit 047a1b87 ("dma-buf & drm/amdgpu: remove
dma_resv workaround") the workaround is no longer needed.  So remove
it.  This effectively reverts commit f1b3f696 ("drm/msm: Don't
break exclusive fence ordering")

Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/509457/
Link: https://lore.kernel.org/r/20221101214051.159988-1-robdclark@gmail.com
parent 7f7a942c
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -334,8 +334,7 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit)
		if (ret)
			return ret;

		/* exclusive fences must be ordered */
		if (no_implicit && !write)
		if (no_implicit)
			continue;

		ret = drm_sched_job_add_implicit_dependencies(&submit->base,