Commit c8e43d55 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: relocate inline conversion from mmap() to mkwrite() 



If there is page fault only for read case on inline inode, we don't need
to convert inline inode, instead, let's do conversion for write case.

Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 39f71b7e

fs/f2fs/file.c

+4 −6
Original line number Diff line number Diff line
@@ -72,6 +72,10 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) 
		goto err;

	}



	err = f2fs_convert_inline_inode(inode);

	if (err)

		goto err;



#ifdef CONFIG_F2FS_FS_COMPRESSION

	if (f2fs_compressed_file(inode)) {

		int ret = f2fs_is_compressed_cluster(inode, page->index);
@@ -506,7 +510,6 @@ static loff_t f2fs_llseek(struct file *file, loff_t offset, int whence) 
static int f2fs_file_mmap(struct file *file, struct vm_area_struct *vma)

{

	struct inode *inode = file_inode(file);

	int err;



	if (unlikely(f2fs_cp_error(F2FS_I_SB(inode))))

		return -EIO;
@@ -514,11 +517,6 @@ static int f2fs_file_mmap(struct file *file, struct vm_area_struct *vma) 
	if (!f2fs_is_compress_backend_ready(inode))

		return -EOPNOTSUPP;



	/* we don't need to use inline_data strictly */

	err = f2fs_convert_inline_inode(inode);

	if (err)

		return err;



	file_accessed(file);

	vma->vm_ops = &f2fs_file_vm_ops;

	set_inode_flag(inode, FI_MMAP_FILE);