Commit c8dec745 authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPICA: Dispatcher: Fix a resource leak issue in acpi_ds_auto_serialize_method(). 

ACPICA commit 29d03840cbab435e8ea82e9339ff9d84535c647d

This patch fixes a resource leak issue in acpi_ds_auto_serialize_method().
It is reported by the "Coverity" tool as unsecure code. Lv Zheng.

Link: https://github.com/acpica/acpica/commit/29d03840
Link: https://jira01.devtools.intel.com/browse/LCK-2142


Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9ab8cf1b

drivers/acpi/acpica/dsmethod.c

+2 −3
Original line number Diff line number Diff line
@@ -116,6 +116,7 @@ acpi_ds_auto_serialize_method(struct acpi_namespace_node *node, 
	walk_state =

	    acpi_ds_create_walk_state(node->owner_id, NULL, NULL, NULL);

	if (!walk_state) {

		acpi_ps_free_op(op);

		return_ACPI_STATUS(AE_NO_MEMORY);

	}
@@ -125,6 +126,7 @@ acpi_ds_auto_serialize_method(struct acpi_namespace_node *node, 
				  obj_desc->method.aml_length, NULL, 0);

	if (ACPI_FAILURE(status)) {

		acpi_ds_delete_walk_state(walk_state);

		acpi_ps_free_op(op);

		return_ACPI_STATUS(status);

	}
@@ -133,9 +135,6 @@ acpi_ds_auto_serialize_method(struct acpi_namespace_node *node, 
	/* Parse the method, scan for creation of named objects */



	status = acpi_ps_parse_aml(walk_state);

	if (ACPI_FAILURE(status)) {

		return_ACPI_STATUS(status);

	}



	acpi_ps_delete_parse_tree(op);

	return_ACPI_STATUS(status);