Commit c8d99bb9 authored by Rob Clark's avatar Rob Clark
Browse files

drm/msm: Fix legacy relocs path 



In moving code around, we ended up using the same pointer to
copy_from_user() the relocs tables as we used for the cmd table
entry, which is clearly not right.  This went unnoticed because
modern mesa on non-ancent kernels does not actually use relocs.
But this broke ancient mesa on modern kernels.

Reported-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Fixes: 20224d71 ("drm/msm/submit: Move copy_from_user ahead of locking bos")
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarAkhil P Oommen <akhilpo@codeaurora.org>
parent 7df222c3

drivers/gpu/drm/msm/msm_gem_submit.c

+2 −0
Original line number Diff line number Diff line
@@ -198,6 +198,8 @@ static int submit_lookup_cmds(struct msm_gem_submit *submit, 
		submit->cmd[i].idx  = submit_cmd.submit_idx;

		submit->cmd[i].nr_relocs = submit_cmd.nr_relocs;



		userptr = u64_to_user_ptr(submit_cmd.relocs);



		sz = array_size(submit_cmd.nr_relocs,

				sizeof(struct drm_msm_gem_submit_reloc));

		/* check for overflow: */