Commit c8cc4cf6 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jonathan Cameron
Browse files

iio: frequency: adf4350: disable reg and clk on error in adf4350_probe() 



Disable reg and clk when devm_gpiod_get_optional() fails in adf4350_probe().

Fixes:4a89d2f4 ("iio: adf4350: Convert to use GPIO descriptor")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20210601142605.3613605-1-yangyingliang@huawei.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 8090d674

drivers/iio/frequency/adf4350.c

+4 −2
Original line number Diff line number Diff line
@@ -563,8 +563,10 @@ static int adf4350_probe(struct spi_device *spi) 


	st->lock_detect_gpiod = devm_gpiod_get_optional(&spi->dev, NULL,

							GPIOD_IN);

	if (IS_ERR(st->lock_detect_gpiod))

		return PTR_ERR(st->lock_detect_gpiod);

	if (IS_ERR(st->lock_detect_gpiod)) {

		ret = PTR_ERR(st->lock_detect_gpiod);

		goto error_disable_reg;

	}



	if (pdata->power_up_frequency) {

		ret = adf4350_set_freq(st, pdata->power_up_frequency);