Commit c8c384d7 authored by Mark Rutland's avatar Mark Rutland Committed by Will Deacon
Browse files

arm64: remove current_top_of_stack() 



We no longer use current_top_of_stack() on arm64, so it can be removed.

We introduced current_top_of_stack() for STACKLEAK in commit:

  0b3e3366 ("arm64: Add support for STACKLEAK gcc plugin")

... then we figured out the intended semantics were unclear, and
reworked it in commit:

  e85094c3 ("arm64: stackleak: fix current_top_of_stack()")

... then we removed the only user in commit:

  0cfa2ccd ("stackleak: rework stack high bound handling")

Given that it's no longer used, and it's very easy to misuse, this patch
removes current_top_of_stack(). For the moment, on_thread_stack() is
left where it is as moving it will change some header dependencies.

There should be no functional change as a result of this patch.

Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Will Deacon <will@kernel.org>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20221117120902.3974163-2-mark.rutland@arm.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent f0c4d9fc

arch/arm64/include/asm/processor.h

+0 −11
Original line number Diff line number Diff line
@@ -396,17 +396,6 @@ long get_tagged_addr_ctrl(struct task_struct *task); 
#define GET_TAGGED_ADDR_CTRL()		get_tagged_addr_ctrl(current)

#endif



/*

 * For CONFIG_GCC_PLUGIN_STACKLEAK

 *

 * These need to be macros because otherwise we get stuck in a nightmare

 * of header definitions for the use of task_stack_page.

 */



/*

 * The top of the current task's task stack

 */

#define current_top_of_stack()	((unsigned long)current->stack + THREAD_SIZE)

#define on_thread_stack()	(on_task_stack(current, current_stack_pointer, 1))



#endif /* __ASSEMBLY__ */