Commit c8c165de authored by Lv Yunlong's avatar Lv Yunlong Committed by Martin K. Petersen
Browse files

scsi: st: Fix a use after free in st_open() 

In st_open(), if STp->in_use is true, STp will be freed by
scsi_tape_put(). However, STp is still used by DEBC_printk() after. It is
better to DEBC_printk() before scsi_tape_put().

Link: https://lore.kernel.org/r/20210311064636.10522-1-lyl2019@mail.ustc.edu.cn


Acked-by: default avatarKai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: default avatarLv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2bb81771

drivers/scsi/st.c

+1 −1
Original line number Diff line number Diff line
@@ -1269,8 +1269,8 @@ static int st_open(struct inode *inode, struct file *filp) 
	spin_lock(&st_use_lock);

	if (STp->in_use) {

		spin_unlock(&st_use_lock);

		scsi_tape_put(STp);

		DEBC_printk(STp, "Device already in use.\n");

		scsi_tape_put(STp);

		return (-EBUSY);

	}